Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-999] explorer frontend: Replace @GITREV@ with actual rev #3386

Merged
merged 1 commit into from
Aug 20, 2018
Merged

[DEVOPS-999] explorer frontend: Replace @GITREV@ with actual rev #3386

merged 1 commit into from
Aug 20, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 13, 2018

Description

Cardano explorer was showing v. 0.2.0( @GITREV ) in the footer.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-999

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

nix-build -A cardano-sl-explorer-frontend
cd result
grep -Ri gitrev
# check for absence of @GITREV@
python3 -m http.server --bind 127.0.0.1 8000
# check that site footer is correct

QA Steps

  1. Check the cardano explorer site footer for a correct git revision.

@rvl rvl requested a review from a team August 13, 2018 03:08
@rvl rvl requested a review from iohk-devops as a code owner August 13, 2018 03:08
angerman
angerman previously approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we somehow do a post build check that verifies there are no placeholders left in the generated source?

@rvl
[DEVOPS-999] explorer frontend: Replace @gitrev@ with actual rev
359ae7e 
This fix is for the release/1.3.1 branch -- where gitrev changes
invalidate the build cache.
@rvl rvl force-pushed the devops-999-explorer-gitrev-release-1.3.1 branch from 87e82b2 to 359ae7e Compare August 16, 2018 13:38
jmitchell
jmitchell approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@jmitchell jmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified according to @rvl's stated test plan. LGTM

@rvl rvl merged commit 9e0a2a2 into release/1.3.1 Aug 20, 2018
@rvl rvl deleted the devops-999-explorer-gitrev-release-1.3.1 branch August 20, 2018 22:02
@rvl rvl mentioned this pull request Aug 24, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmitchell jmitchell jmitchell approved these changes

@angerman angerman angerman left review comments

@iohk-devops iohk-devops Awaiting requested review from iohk-devops iohk-devops is a code owner

Assignees
No one assigned
Labels
release-1.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvl @angerman @jmitchell